Conversation
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
Have you tested this with a real Bash 3.0 binary?
| @@ -239,7 +239,7 @@ function helpers::find_total_tests() { | |||
| for fn_name in "${functions_to_run[@]}"; do | |||
| local provider_data=() | |||
There was a problem hiding this comment.
In Bash 3.0, this doesn't work. This is equivalent to local provider_data='()' and creates a scalar variable containing the string '()' in Bash 3.0.
I just noticed this by looking at the diff, but I haven't checked the entire codebase. There could still be other compatibility issues.
There was a problem hiding this comment.
Thanks for the feedback. I didn't tested with real bash 3.0 binary as I had to leave after I created the PR and wanted to know how far away from the final result this would be. I will continue with it and test it with bash 3.0 binary this weekend. Also, I should find a way to setup this bash 3.0 in the CI to run all tests using that version
|
Closes in favor of #493 |
2 participants
📚 Description
Right now the min supported version is bash 3.2
🔖 Changes
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix